Task #3128
closednom 5
Description
Nom 5 is out. It claims to be a bit more efficient and more developer friendly.
Unknown at this time how much effort it would take to switch.
Updated by Victor Julien over 5 years ago
- Status changed from New to Assigned
- Assignee set to Pierre Chifflier
Updated by Pierre Chifflier about 5 years ago
Small update on this: most of the update has been done, and pushed on https://github.com/chifflier/suricata/tree/dev/nom5-v1
This is a rather intrusive update, only the first part is done here (basic upgrade to nom 5). A second PR will be written later to update parsers to use functions and closures instead of macros, but has been split for readability/review reasons.
Some unit tests (cargo test) broke, and are being fixed.
Sidenote: having unit tests in cargo test is great for spotting these kind of regressions, we must encourage people to write them!
Updated by Victor Julien about 5 years ago
- Blocked by Optimization #3308: rust: use cbindgen to generate bindings added
Updated by Victor Julien about 5 years ago
Thanks Pierre, please do a pull request for the straight nom 5 conversion after cbindgen support is merged. I agree the nom 5 switch and then the macro removal PR should be different steps.
Updated by Victor Julien about 5 years ago
- Target version changed from TBD to 6.0.0beta1
Updated by Victor Julien almost 5 years ago
- Status changed from Assigned to In Review
Updated by Victor Julien almost 5 years ago
- Status changed from In Review to Closed