Project

General

Profile

Actions

Task #3128

closed
VJ PC

nom 5

Task #3128: nom 5

Added by Victor Julien over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:

Description

Nom 5 is out. It claims to be a bit more efficient and more developer friendly.

Unknown at this time how much effort it would take to switch.


Related issues 1 (0 open1 closed)

Blocked by Suricata - Optimization #3308: rust: use cbindgen to generate bindingsClosedDanny BrowningActions

VJ Updated by Victor Julien over 6 years ago Actions #1

  • Status changed from New to Assigned
  • Assignee set to Pierre Chifflier

PC Updated by Pierre Chifflier over 6 years ago Actions #2

Small update on this: most of the update has been done, and pushed on https://github.com/chifflier/suricata/tree/dev/nom5-v1
This is a rather intrusive update, only the first part is done here (basic upgrade to nom 5). A second PR will be written later to update parsers to use functions and closures instead of macros, but has been split for readability/review reasons.

Some unit tests (cargo test) broke, and are being fixed.

Sidenote: having unit tests in cargo test is great for spotting these kind of regressions, we must encourage people to write them!

VJ Updated by Victor Julien over 6 years ago Actions #3

VJ Updated by Victor Julien over 6 years ago Actions #4

Thanks Pierre, please do a pull request for the straight nom 5 conversion after cbindgen support is merged. I agree the nom 5 switch and then the macro removal PR should be different steps.

VJ Updated by Victor Julien over 6 years ago Actions #5

  • Target version changed from TBD to 6.0.0beta1

PC Updated by Pierre Chifflier about 6 years ago Actions #6

Submitted as PR#4523

VJ Updated by Victor Julien about 6 years ago Actions #7

  • Status changed from Assigned to In Review
Actions

Also available in: PDF Atom