Project

General

Profile

Actions

Task #3128

closed

nom 5

Added by Victor Julien about 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Target version:
Effort:
Difficulty:
Label:

Description

Nom 5 is out. It claims to be a bit more efficient and more developer friendly.

Unknown at this time how much effort it would take to switch.


Related issues

Blocked by Optimization #3308: rust: use cbindgen to generate bindingsClosedDanny BrowningActions
Actions #1

Updated by Victor Julien about 2 years ago

  • Status changed from New to Assigned
  • Assignee set to Pierre Chifflier
Actions #2

Updated by Pierre Chifflier almost 2 years ago

Small update on this: most of the update has been done, and pushed on https://github.com/chifflier/suricata/tree/dev/nom5-v1
This is a rather intrusive update, only the first part is done here (basic upgrade to nom 5). A second PR will be written later to update parsers to use functions and closures instead of macros, but has been split for readability/review reasons.

Some unit tests (cargo test) broke, and are being fixed.

Sidenote: having unit tests in cargo test is great for spotting these kind of regressions, we must encourage people to write them!

Actions #3

Updated by Victor Julien almost 2 years ago

Actions #4

Updated by Victor Julien almost 2 years ago

Thanks Pierre, please do a pull request for the straight nom 5 conversion after cbindgen support is merged. I agree the nom 5 switch and then the macro removal PR should be different steps.

Actions #5

Updated by Victor Julien almost 2 years ago

  • Target version changed from TBD to 6.0.0beta1
Actions #6

Updated by Pierre Chifflier over 1 year ago

Submitted as PR#4523

Actions #7

Updated by Victor Julien over 1 year ago

  • Status changed from Assigned to In Review
Actions

Also available in: Atom PDF