Project

General

Custom queries

Profile

Actions
Copy link

Optimization #3827

closed

output: clean up logging initialization code

Added by Victor Julien almost 5 years ago. Updated 29 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Philippe Antoine
Target version:
8.0.0-beta1
Effort:
Difficulty:
Label:

Description

Currently all loggers have setup and shutdown code that is very similar, and the rust loggers still have a fair bit of a C glue code as well.

Related issues 13 (3 open — 10 closed)

Related to Suricata - Bug #5977: eve/alert: missing KRB5 metadataClosedPhilippe AntoineActions
Related to Suricata - Task #4101: tracking: pluginsIn ProgressJason IshActions
Related to Suricata - Task #5053: app-layer: dynamic alproto IDsClosedPhilippe AntoineActions
Related to Suricata - Bug #6501: eve/alert: missing TFTP metadataClosedPhilippe AntoineActions
Related to Suricata - Bug #6500: eve/alert: missing FTP metadataClosedPhilippe AntoineActions
Related to Suricata - Feature #6090: eve/alert: missing dcerpc metadataClosedPhilippe AntoineActions
Related to Suricata - Feature #6091: eve/alert: missing dhcp metadataNewOISF DevActions
Related to Suricata - Bug #6092: eve/alert: missing pgsql metadataClosedJuliana Fajardini ReichowActions
Related to Suricata - Bug #6400: log of DNS answer is in wrong direction NewEric LeblondActions
Blocks Suricata - Task #4683: detect: remove sigmatch_table in favor of a dynamic storage optionClosedPhilippe AntoineActions
Blocks Suricata - Feature #3958: enip: convert protocol parser to rustClosedPhilippe AntoineActions
Blocks Suricata - Feature #2695: websocket supportClosedPhilippe AntoineActions
Blocks Suricata - Feature #5773: doh: support DNS over HTTPS (DoH)ClosedPhilippe AntoineActions
Actions
Copy link
 #1

Updated by Victor Julien over 2 years ago

  • Target version changed from 7.0.0-beta1 to 7.0.0-rc1
Actions
Copy link
 #2

Updated by Victor Julien over 2 years ago

  • Target version changed from 7.0.0-rc1 to 8.0.0-beta1
Actions
Copy link
 #3

Updated by Philippe Antoine almost 2 years ago

@Jason Ish would you assign me this ?
https://github.com/OISF/suricata/pull/8961 is doing this

Actions
Copy link
 #4

Updated by Jason Ish almost 2 years ago

  • Assignee changed from Jason Ish to Philippe Antoine
Actions
Copy link
 #5

Updated by Philippe Antoine almost 2 years ago

  • Status changed from Assigned to In Progress
  • Target version changed from 8.0.0-beta1 to 7.0.1
Actions
Copy link
 #6

Updated by Philippe Antoine almost 2 years ago

  • Related to Bug #5977: eve/alert: missing KRB5 metadata added
Actions
Copy link
 #7

Updated by Philippe Antoine almost 2 years ago

  • Status changed from In Progress to In Review

https://github.com/OISF/suricata/pull/9252 is a first PR, unblocking #5977
Second PR to close this would reusing these SimpleTxLogFunc from a JsonGenericLogger to remove many C files (as proposed in draft https://github.com/OISF/suricata/pull/8961 )

Actions
Copy link
 #8

Updated by Victor Julien almost 2 years ago

  • Target version changed from 7.0.1 to 8.0.0-beta1

This type of cleanup work is not for a patch release.

Actions
Copy link
 #9

Updated by Philippe Antoine over 1 year ago

Actions
Copy link
 #10

Updated by Philippe Antoine over 1 year ago

  • Related to Task #5053: app-layer: dynamic alproto IDs added
Actions
Copy link
 #11

Updated by Philippe Antoine over 1 year ago

  • Related to Bug #6501: eve/alert: missing TFTP metadata added
Actions
Copy link
 #12

Updated by Philippe Antoine over 1 year ago

  • Related to Bug #6500: eve/alert: missing FTP metadata added
Actions
Copy link
 #13

Updated by Philippe Antoine over 1 year ago

  • Related to Feature #6090: eve/alert: missing dcerpc metadata added
Actions
Copy link
 #14

Updated by Philippe Antoine over 1 year ago

  • Related to Feature #6091: eve/alert: missing dhcp metadata added
Actions
Copy link
 #15

Updated by Philippe Antoine over 1 year ago

  • Related to Bug #6092: eve/alert: missing pgsql metadata added
Actions
Copy link
 #16

Updated by Philippe Antoine over 1 year ago

  • Related to Bug #6400: log of DNS answer is in wrong direction added
Actions
Copy link
 #17

Updated by Philippe Antoine over 1 year ago

  • Blocks Task #4683: detect: remove sigmatch_table in favor of a dynamic storage option added
Actions
Copy link
 #18

Updated by Philippe Antoine over 1 year ago

  • Blocks Feature #3958: enip: convert protocol parser to rust added
Actions
Copy link
 #19

Updated by Philippe Antoine over 1 year ago

Actions
Copy link
 #20

Updated by Philippe Antoine over 1 year ago

Actions
Copy link
 #21

Updated by Philippe Antoine about 1 year ago

  • Status changed from In Review to Closed
Actions
Copy link
 #22

Updated by Victor Julien 29 days ago

  • Subject changed from clean up logging initialization code to output: clean up logging initialization code
Actions
Copy link

Also available in: Atom PDF