Project

General

Profile

Actions
Copy link

Bug #5186

closed
BS JL

tenant_id should have consistent data type across all structs

Bug #5186: tenant_id should have consistent data type across all structs

Added by Balachandran Sivakumar about 4 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jeff Lucovsky
Target version:
7.0.0
Affected Versions:
6.0.4
Effort:
Difficulty:
Label:
Needs backport to 6.0

Description

tenant_id is defined as an int in some structures and as uint32_t in some structures. In some edge case values of tenant_id (For eg. 2^32), this can cause problems.

Defined as uint32_t in :
DetectEngineThreadCtx
DetectEngineTenantMapping
Flow
PcapPacketVars_

Defined as int in :
DetectEngineCtx
PcapFiles
param in DetectEngineGetByTenantId(...)
param in DetectEngineLoadTenantBlocking(...)

Actual:
Inconsistent data type for tenant_id across the sources

Expected:
Use a consistent data type for tenant_id across the sources

BS Updated by Balachandran Sivakumar about 4 years ago Actions
Copy link
 #1

  • Assignee changed from OISF Dev to Balachandran Sivakumar

VJ Updated by Victor Julien over 2 years ago Actions
Copy link
 #2

  • Status changed from New to Resolved
  • Assignee changed from Balachandran Sivakumar to Jeff Lucovsky
  • Target version changed from TBD to 7.0.0
  • Label Needs backport to 6.0 added

JL Updated by Jeff Lucovsky over 2 years ago Actions
Copy link
 #3

This commit has already been backported to master-6.0.x: e25082c08493385850c3d4795d7eb92af07a1aa1

JL Updated by Jeff Lucovsky over 2 years ago Actions
Copy link
 #4

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: PDF Atom