Project

General

Profile

Actions
Copy link

Bug #5186

closed

tenant_id should have consistent data type across all structs

Added by Balachandran Sivakumar about 2 years ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Jeff Lucovsky
Target version:
7.0.0
Affected Versions:
6.0.4
Effort:
Difficulty:
Label:
Needs backport to 6.0

Description

tenant_id is defined as an int in some structures and as uint32_t in some structures. In some edge case values of tenant_id (For eg. 2^32), this can cause problems.

Defined as uint32_t in :
DetectEngineThreadCtx
DetectEngineTenantMapping
Flow
PcapPacketVars_

Defined as int in :
DetectEngineCtx
PcapFiles
param in DetectEngineGetByTenantId(...)
param in DetectEngineLoadTenantBlocking(...)

Actual:
Inconsistent data type for tenant_id across the sources

Expected:
Use a consistent data type for tenant_id across the sources

Actions
Copy link

Also available in: Atom PDF