Actions
Bug #5331
closedstacktrace-on-signal: Kills all processes in the same process group
Description
A test in our CI pipeline tickled a Suricata segfault, `stacktrace-on-signal` functionality was enabled and our test driver was killed when re-raising the signal to the whole process group rather than just the Suricata process.
Will open a PR.
Author: Arne Welzel <arne.welzel@corelight.com>
Date: Wed May 4 20:06:36 2022 +0200
stacktrace-on-signal: Use kill(getpid(), sig_num)
kill(0, ...) re-raises the signal to every processes in the process
group which may impact unrelated processes.
Concretely, in our CI pipeline, a segfaulting Suricata process killed
the test driver.
diff --git a/src/suricata.c b/src/suricata.c
index 24ffa0fe6..b246ce13f 100644
--- a/src/suricata.c
+++ b/src/suricata.c
@@ -342,7 +342,7 @@ static void SignalHandlerUnexpected(int sig_num, siginfo_t *info, void *context)
terminate:
// Propagate signal to watchers, if any
- kill(0, sig_num);
+ kill(getpid(), sig_num);
}
Updated by Jason Ish over 3 years ago
- Status changed from New to In Review
Updated by Jeff Lucovsky over 3 years ago
- Assignee changed from OISF Dev to Arne Welzel
Updated by Jeff Lucovsky over 3 years ago
- Copied to Bug #5334: stacktrace-on-signal: Kills all processes in the same process group added
Updated by Jeff Lucovsky over 3 years ago
- Status changed from In Review to Resolved
- Target version changed from TBD to 7.0.0-beta1
Updated by Shivani Bhardwaj about 3 years ago
- Label deleted (
Needs backport to 6.0)
Updated by Victor Julien about 3 years ago
- Status changed from Resolved to Closed
Actions