Actions
Optimization #5785
open
BT
CT
smb: use u32.to_be_bytes to replace function u32_as_bytes
Optimization #5785:
smb: use u32.to_be_bytes to replace function u32_as_bytes
Effort:
Difficulty:
Label:
Beginner, Good First Issue, Rust
Description
I think use std function here is more straightforward.
u32_as_bytes implement: https://github.com/OISF/suricata/blob/55c4834e4e9b14a441b735f84d8d35b4eb151702/rust/src/smb/smb.rs#L670-L676
to_be_bytes document: https://doc.rust-lang.org/std/primitive.u32.html#method.to_be_bytes
PA Updated by Philippe Antoine over 2 years ago
- Label Beginner added
JF Updated by Juliana Fajardini Reichow over 2 years ago
- Assignee changed from b1 tg to Community Ticket
- Target version changed from TBD to 8.0.0-beta1
Hi there, according to our guidelines for stale tickets, I'm unassigning this ticket. Thanks for all your contributions, and feel free to reach out in case you have time and want to contribute to Suricata again :) :)
VJ Updated by Victor Julien almost 2 years ago
- Target version changed from 8.0.0-beta1 to TBD
PA Updated by Philippe Antoine 2 months ago
- Label Good First Issue, Rust added
Actions