Project

General

Profile

Actions
Copy link

Optimization #5785

open

smb: use u32.to_be_bytes to replace function u32_as_bytes

Added by b1 tg almost 2 years ago. Updated 5 months ago.

Status:
New
Priority:
Normal
Assignee:
Community Ticket
Target version:
TBD
Effort:
Difficulty:
Label:
Beginner

Description

I think use std function here is more straightforward.

u32_as_bytes implement: https://github.com/OISF/suricata/blob/55c4834e4e9b14a441b735f84d8d35b4eb151702/rust/src/smb/smb.rs#L670-L676
to_be_bytes document: https://doc.rust-lang.org/std/primitive.u32.html#method.to_be_bytes

Actions
Copy link
 #1

Updated by Philippe Antoine about 1 year ago

  • Label Beginner added
Actions
Copy link
 #2

Updated by Juliana Fajardini Reichow about 1 year ago

  • Assignee changed from b1 tg to Community Ticket
  • Target version changed from TBD to 8.0.0-beta1

Hi there, according to our guidelines for stale tickets, I'm unassigning this ticket. Thanks for all your contributions, and feel free to reach out in case you have time and want to contribute to Suricata again :) :)

Refer to:
https://docs.suricata.io/en/latest/devguide/codebase/contributing/contribution-process.html#stale-tickets-policy

Actions
Copy link
 #3

Updated by Victor Julien 5 months ago

  • Target version changed from 8.0.0-beta1 to TBD
Actions
Copy link

Also available in: Atom PDF