Project

General

Profile

Actions

Optimization #6387

closed
JF JL

mqtt: move parser registration code to the rust side

Optimization #6387: mqtt: move parser registration code to the rust side

Added by Juliana Fajardini Reichow over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Effort:
Difficulty:
Label:
Beginner, C, Outreachy, Rust

Description

Although our MQTT app-layer parser is mostly in rust, some of the parser registration code still resides in app-layer-mqtt.c

It is possible to move that code to Rust, therefore getting rid of the related c files.

This task encompasses:
- moving the existing code from app-layer-mqtt.c to the rust mqtt parser file
- removing now unnecessary app-layer-mqtt.* files
- checking if there's any left over lines of code that must be adjusted.

SP Updated by sakshi patle over 2 years ago Actions #1

Hi, I am interested on working on this issue.

SB Updated by Shivani Bhardwaj over 2 years ago Actions #2

  • Status changed from New to Assigned
  • Assignee changed from Community Ticket to sakshi patle

JF Updated by Juliana Fajardini Reichow over 2 years ago Actions #3

sakshi patle wrote in #note-1:

Hi, I am interested on working on this issue.

I am terribly sorry that I never properly answer you here, Sakshi, somehow, I didn't get the notification of the activity on this ticket. I saw that you claimed it, so I hope this didn't prevent you from starting to work on it!

JL Updated by Jeff Lucovsky over 2 years ago Actions #4

  • Description updated (diff)

JF Updated by Juliana Fajardini Reichow over 2 years ago Actions #5

  • Assignee changed from sakshi patle to Community Ticket

Hi there, according to our guidelines for stale tickets, I'm unassigning this ticket.

Thanks for your interest in our project, and feel free to reach out in case you have time and want to contribute to Suricata again :) :)

Refer to:
https://forum.suricata.io/t/important-outreachy-contribution-phase-wrap-up-prs-claimed-tickets-and-more
https://docs.suricata.io/en/latest/devguide/codebase/contributing/contribution-process.html#stale-tickets-policy

LS Updated by Lukas Sismis over 2 years ago Actions #6

  • Assignee changed from Community Ticket to Lukas Sismis

LS Updated by Lukas Sismis over 2 years ago Actions #7

  • Assignee changed from Lukas Sismis to Jeff Lucovsky

JL Updated by Jeff Lucovsky over 2 years ago Actions #8

  • Status changed from Assigned to In Review

PA Updated by Philippe Antoine over 2 years ago Actions #9

  • Status changed from In Review to Closed
Actions

Also available in: PDF Atom