Feature #6396: Add protocol string support for mqtt - Suricata - Open Information Security Foundation

Actions

Copy link

Feature #6396

closed

Add protocol string support for mqtt

Added by Jason Taylor about 1 year ago. Updated about 1 year ago.

Status:

Closed

Priority:

Normal

Assignee:

Sascha Steinbiss

Target version:

8.0.0-beta1

Effort:

Difficulty:

Label:

C, Needs Suricata-Verify test, Rust

Description

we would like the ability to sig on the protocol string content on mqtt traffic. The key/value is currently being logged:

"mqtt":{"connect":{"qos":0,"retain":false,"dup":false,"protocol_string":"MQIsdp","protocol_version":3,"client_id":"<snipped>

So something like mqtt.protocol_string would be great.

Actions

Copy link

Updated by Jason Taylor about 1 year ago

When looking at the mqtt sources, I noticed what are probably the remnants from a copy/paste in detect-mqtt-type.c:

/** * \brief Registration function for ipopts: keyword
*/

Totally a minor thing of course just figured a fixup could go in with this tickets main work

Actions

Copy link

Updated by Sascha Steinbiss about 1 year ago

Status changed from New to In Progress
Label C, Needs Suricata-Verify test, Rust added

Actions

Copy link

Updated by Sascha Steinbiss about 1 year ago

Jason Taylor wrote in #note-1:

When looking at the mqtt sources, I noticed what are probably the remnants from a copy/paste in detect-mqtt-type.c:
/**

\brief Registration function for ipopts: keyword
*/

Totally a minor thing of course just figured a fixup could go in with this tickets main work

True, will include that in the PR. Thanks for spotting this!

Actions

Copy link