Bug #7000
openOptimization #7026: app-protos: trigger raw stream reassembly
pgsql: partially incorrect tx_id tracking
Description
When a new PgsqlTransaction was created, the tx_id was adjusted to start at 1.
Disconsidering this, get_tx and free_tx were still incrementing tx_id when performing their logics,
leading to discrepancies when logging alert metadata for pgsql (to name one that we were able to notice).
This might also happen with template.rs, will investigate.
---------------
Update: turns out that the template code also takes this into consideration, as well as the core of the engine.
So the solution here was actually to trigger the raw stream reassembly earlier, so, I added this one as a sub ticket of #7026
Updated by Juliana Fajardini Reichow 4 months ago
- Status changed from In Progress to In Review
PR for review: https://github.com/OISF/suricata/pull/10997
Updated by Juliana Fajardini Reichow 4 months ago
According to further investigation by Jason, it doesn't seem that the fix is needed for template.rs (cf https://github.com/OISF/suricata/pull/10997#discussion_r1585608422)
Updated by Juliana Fajardini Reichow 4 months ago
- Related to Optimization #7018: dns/tcp: allow triggering raw stream reassembly added
Updated by Juliana Fajardini Reichow 3 months ago
- Status changed from In Review to Resolved
Merged with: https://github.com/OISF/suricata/pull/11253
Updated by Juliana Fajardini Reichow 3 months ago
- Parent task set to #7026
The solution here was actually to trigger the raw stream reassembly earlier, so, I'll add this one as a subticket of #7026
Updated by Victor Julien 3 months ago
- Related to Bug #7113: pgsql: track 'progress' in tx per direction added