Project

General

Profile

Actions

Security #7209

closed
JI PA

thash: random factor not used; possible abusive hash collisions

Security #7209: thash: random factor not used; possible abusive hash collisions

Added by Jason Ish over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Target version:
Affected Versions:
Label:
Git IDs:

26da953f6dad3793d29f27ce7ab6628a2db8f471

Severity:
CRITICAL
Disclosure Date:

Description

util-thash.c initializes a random factor, however, this is not used. I suspect the intention was to introduce some randomness.


Subtasks 1 (0 open1 closed)

Security #7258: thash: random factor not used; possible abusive hash collisions (7.0.x backport)ClosedPhilippe AntoineActions

Related issues 2 (1 open1 closed)

Related to Suricata - Optimization #3322: Use standard CRC32 for hash-like functionsAssignedCommunity TicketActions
Related to Suricata - Security #7289: http: missing hashtable random seed leads to potential DoSClosedPhilippe AntoineActions

PA Updated by Philippe Antoine over 1 year ago Actions #1

cf usage of StringHashDjb2 in ContainerUrlRangeHash, network traffic induced

VJ Updated by Victor Julien over 1 year ago Actions #3

  • Label Needs backport to 7.0 added

VJ Updated by Victor Julien over 1 year ago Actions #4

  • Target version changed from TBD to 8.0.0-beta1

OT Updated by OISF Ticketbot over 1 year ago Actions #5

  • Subtask #7258 added

OT Updated by OISF Ticketbot over 1 year ago Actions #6

  • Label deleted (Needs backport to 7.0)

PA Updated by Philippe Antoine over 1 year ago Actions #7

git grep 5381 shows a lot of redefinition of StringHashDjb2

PA Updated by Philippe Antoine over 1 year ago Actions #8

  • Status changed from New to In Review

Gitlab POC

PA Updated by Philippe Antoine over 1 year ago Actions #9

VJ Updated by Victor Julien over 1 year ago Actions #10

  • Tracker changed from Bug to Security
  • Assignee changed from OISF Dev to Philippe Antoine
  • Severity set to CRITICAL

JF Updated by Juliana Fajardini Reichow over 1 year ago Actions #11

  • Related to Security #7289: http: missing hashtable random seed leads to potential DoS added

PA Updated by Philippe Antoine over 1 year ago Actions #14

  • Git IDs updated (diff)

VJ Updated by Victor Julien over 1 year ago Actions #15

  • Private changed from Yes to No
Actions

Also available in: PDF Atom