Bug #1484
closedsrc: BUG_ON(1) statements in the packet path
Added by Victor Julien almost 11 years ago. Updated 10 months ago.
JI Updated by Jason Ish almost 11 years ago Actions #1
Do you really want them out of the packet path?
One school of thought is to liberally use assertions, but have them enabled as a compile time option - typically enabled during development, but off by default for production use.
VJ Updated by Victor Julien almost 11 years ago Actions #2
I don't mind keeping them in some form (DEBUG_VALIDATION comes to mind), but we can't just switch the BUG_ON macro to do that w/o reviewing all places it is used now. In this specific case, the assertion would have to move up a bit, and only trigger the EBUSY case. Thats the only bug/issue really, as the NOMEM case could be triggered by memcaps being reached.
VJ Updated by Victor Julien over 10 years ago Actions #3
- Target version changed from 3.0RC1 to 70
VJ Updated by Victor Julien about 10 years ago Actions #4
- % Done changed from 0 to 20
DNS BUG_ON's removed through: https://github.com/inliniac/suricata/pull/1915
Not sure how many are left.
VJ Updated by Victor Julien over 7 years ago Actions #5
- Assignee changed from Jason Ish to OISF Dev
AH Updated by Andreas Herz almost 7 years ago Actions #6
Some are left :)
src/detect-tag.c: BUG_ON(1); src/detect-flowint.c: BUG_ON(1); src/util-unittest.h: BUG_ON(1); \ src/detect-engine-sigorder.c: BUG_ON(1); src/detect-engine-sigorder.c: BUG_ON(1); src/detect-engine-sigorder.c: BUG_ON(1); src/detect-engine-sigorder.c: BUG_ON(1); src/detect-engine-sigorder.c: BUG_ON(1); src/detect-engine-sigorder.c: BUG_ON(1); src/detect-engine.c: BUG_ON(1); src/detect-engine.c: BUG_ON(1); src/detect-engine.c: BUG_ON(1); src/detect-engine.c: BUG_ON(1); src/detect-engine-mpm.c: BUG_ON(1); src/detect-engine-port.c: BUG_ON(1); src/app-layer-ssh.c: BUG_ON(1);// we only call this when we have enough data src/source-af-packet.c: BUG_ON(1); src/detect-filestore.c: BUG_ON(1); src/detect-engine-content-inspection.c: BUG_ON(1); src/flow-timeout.c: BUG_ON(1); src/tm-threads.c: BUG_ON(1); src/detect-engine-build.c: BUG_ON(1); src/util-validate.h: BUG_ON(1); \ src/util-unittest-helper.c: BUG_ON(1); src/util-unittest-helper.c: BUG_ON(1); src/tests/detect.c: BUG_ON(1); src/tests/detect.c: BUG_ON(1); src/tests/detect.c: BUG_ON(1); src/tests/detect.c: BUG_ON(1);
AH Updated by Andreas Herz almost 7 years ago Actions #7
- Target version changed from 70 to TBD
VJ Updated by Victor Julien over 6 years ago Actions #8
- Status changed from Assigned to New
- Label Beginner added
PA Updated by Philippe Antoine over 1 year ago Actions #9
- Label Hardening added
PA Updated by Philippe Antoine over 1 year ago Actions #10
Also some direct `abort()`
PA Updated by Philippe Antoine 11 months ago Actions #11
- Status changed from New to In Review
- Assignee changed from OISF Dev to Philippe Antoine
- Target version changed from TBD to 8.0.0
PA Updated by Philippe Antoine 11 months ago Actions #12
- Related to Bug #7791: http: BUG_ON assertion reached in packet path added
PA Updated by Philippe Antoine 10 months ago Actions #13
- Status changed from In Review to Closed
SB Updated by Shivani Bhardwaj 10 months ago Actions #14
- Subject changed from Remove BUG_ON(1) statements in the packet path to src: BUG_ON(1) statements in the packet path