Project

General

Profile

Actions

Bug #5113

closed

Off-by-one in flow-manager flow_hash row allocation

Added by Jeff Lucovsky 9 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Affected Versions:
Effort:
low
Difficulty:
Label:

Description

When configuring more than one flow manager, a single row between the per-flow-manager ranges is left-out.

The current code doesn't cover all rows when more than one flow manager is
used. It leaves a single row between ftd->max and ftd->min of the next
manager orphaned. As an example:

hash_size=1000
flowmgr_number=3
range=333

instance  ftd->min  ftd->max
0         0         333
1         334       666
2         667       1000

Rows not covered: 333, 666

PR: https://github.com/OISF/suricata/pull/6993


Related issues 1 (0 open1 closed)

Copied from Bug #5073: Off-by-one in flow-manager flow_hash row allocationClosedArne WelzelActions
Actions #1

Updated by Jeff Lucovsky 9 months ago

  • Copied from Bug #5073: Off-by-one in flow-manager flow_hash row allocation added
Actions #2

Updated by Victor Julien 8 months ago

  • Target version changed from 5.0.9 to 5.0.10

Needs investigation if this is a real issue in 5. Flow engine was largely rewritten in 6+.

Actions #3

Updated by Jeff Lucovsky 7 months ago

  • Status changed from Assigned to In Progress

Cherry-pick commit(s):
- 8ef066318d7c4dd9b6686dbebd621c790828c384

Actions #4

Updated by Jeff Lucovsky 7 months ago

  • Status changed from In Progress to In Review
Actions #5

Updated by Jeff Lucovsky 7 months ago

  • Status changed from In Review to Closed
Actions

Also available in: Atom PDF