Project

General

Profile

Actions
Copy link

Optimization #5672

closed

Task #5682: tracking: smb performance issues

smb: avoid unbounded hash maps

Added by Philippe Antoine almost 3 years ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Victor Julien
Target version:
8.0.0-beta1
Effort:
Difficulty:
Label:

Subtasks 1 (0 open — 1 closed)

Security #7183: smb: hashmap entries not removed for error responsesClosedOISF DevActions

Related issues 3 (2 open — 1 closed)

Related to Suricata - Task #5488: Suricon 2022 brainstormAssignedVictor JulienActions
Related to Suricata - Security #6680: smb: pcap with many open files takes too much timeClosedPhilippe AntoineActions
Related to Suricata - Optimization #7371: smb: events/counters for caches getting fullNewOISF DevActions
Actions
Copy link
 #1

Updated by Philippe Antoine almost 3 years ago

  • Related to Task #5488: Suricon 2022 brainstorm added
Actions
Copy link
 #2

Updated by Victor Julien almost 3 years ago

  • Priority changed from Normal to High
  • Target version changed from TBD to 8.0.0-beta1
Actions
Copy link
 #3

Updated by Victor Julien almost 3 years ago

  • Parent task set to #5682
Actions
Copy link
 #4

Updated by Victor Julien almost 3 years ago

There are several hashmaps per state. Couple of thoughts:
1. do we really need all of them still?
2. should each of them be per state... maybe it actually makes sense to have more global ones?
3. like with the file housekeeping logic, we should probably have a hashmap housekeeping

Actions
Copy link
 #5

Updated by Victor Julien over 1 year ago

  • Related to Security #6680: smb: pcap with many open files takes too much time added
Actions
Copy link
 #6

Updated by Jeff Lucovsky over 1 year ago ยท Edited

  • Assignee changed from OISF Dev to Jeff Lucovsky
Actions
Copy link
 #7

Updated by Victor Julien over 1 year ago

  • Status changed from New to Assigned
Actions
Copy link
 #8

Updated by Victor Julien about 1 year ago

  • Subtask #7183 added
Actions
Copy link
 #9

Updated by Victor Julien about 1 year ago

  • Status changed from Assigned to In Progress
  • Assignee changed from Jeff Lucovsky to Victor Julien
Actions
Copy link
 #10

Updated by Victor Julien about 1 year ago

  • Status changed from In Progress to In Review
Actions
Copy link
 #11

Updated by Victor Julien 10 months ago

  • Subtask #7371 added
Actions
Copy link
 #12

Updated by Victor Julien 10 months ago

  • Status changed from In Review to Resolved
Actions
Copy link
 #13

Updated by Victor Julien about 1 month ago

  • Subtask deleted (#7371)
Actions
Copy link
 #14

Updated by Victor Julien about 1 month ago

Actions
Copy link
 #15

Updated by Victor Julien about 1 month ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF