Optimization #5672: smb: avoid unbounded hash maps - Suricata - Open Information Security Foundation

Custom queries

8.0.0 Stories
Good First Issues
OISF community
Open Doc tasks

Actions

Copy link

Optimization #5672

closed

PA VJ

Task #5682: tracking: smb performance issues

smb: avoid unbounded hash maps

Optimization #5672: smb: avoid unbounded hash maps

Added by Philippe Antoine over 3 years ago. Updated 8 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Victor Julien

Target version:

8.0.0-beta1

Effort:

Difficulty:

Label:

Subtasks 1 (0 open — 1 closed)

Security #7183: smb: hashmap entries not removed for error responses

Closed

OISF Dev

Actions

Related issues 3 (2 open — 1 closed)

Related to Suricata - Task #5488: Suricon 2022 brainstorm	Assigned	Victor Julien	Actions
Related to Suricata - Security #6680: smb: pcap with many open files takes too much time	Closed	Philippe Antoine	Actions
Related to Suricata - Optimization #7371: smb: events/counters for caches getting full	Assigned	OISF Dev	Actions

Issue # Delay: days Cancel Multiple values allowed (comma separated).

History
Notes
Property changes

PA Updated by Philippe Antoine over 3 years ago Actions
Copy link
#1

Related to Task #5488: Suricon 2022 brainstorm added

VJ Updated by Victor Julien over 3 years ago Actions
Copy link
#2

Priority changed from Normal to High
Target version changed from TBD to 8.0.0-beta1

VJ Updated by Victor Julien over 3 years ago Actions
Copy link
#3

Parent task set to #5682

VJ Updated by Victor Julien over 3 years ago Actions
Copy link
#4

There are several hashmaps per state. Couple of thoughts:
1. do we really need all of them still?
2. should each of them be per state... maybe it actually makes sense to have more global ones?
3. like with the file housekeeping logic, we should probably have a hashmap housekeeping

VJ Updated by Victor Julien about 2 years ago Actions
Copy link
#5

Related to Security #6680: smb: pcap with many open files takes too much time added

JL Updated by Jeff Lucovsky almost 2 years ago · Edited Actions
Copy link
#6

Assignee changed from OISF Dev to Jeff Lucovsky

VJ Updated by Victor Julien almost 2 years ago Actions
Copy link
#7

Status changed from New to Assigned

VJ Updated by Victor Julien over 1 year ago Actions
Copy link
#8

Subtask #7183 added

VJ Updated by Victor Julien over 1 year ago Actions
Copy link
#9

Status changed from Assigned to In Progress
Assignee changed from Jeff Lucovsky to Victor Julien

VJ Updated by Victor Julien over 1 year ago Actions
Copy link
#10

Status changed from In Progress to In Review

https://github.com/OISF/suricata/pull/11721

VJ Updated by Victor Julien over 1 year ago Actions
Copy link
#11

Subtask #7371 added

VJ Updated by Victor Julien over 1 year ago Actions
Copy link
#12

Status changed from In Review to Resolved

https://github.com/OISF/suricata/pull/12087

VJ Updated by Victor Julien 8 months ago Actions
Copy link
#13

Subtask deleted (~~#7371~~)

VJ Updated by Victor Julien 8 months ago Actions
Copy link
#14

Related to Optimization #7371: smb: events/counters for caches getting full added

VJ Updated by Victor Julien 8 months ago Actions
Copy link
#15

Status changed from Resolved to Closed

Actions

Copy link

Also available in: PDF Atom

Project

General

Profile

Suricata

Custom queries

Optimization #5672

smb: avoid unbounded hash maps

PA Updated by Philippe Antoine over 3 years ago Actions
Copy link
#1

VJ Updated by Victor Julien over 3 years ago Actions
Copy link
#2

VJ Updated by Victor Julien over 3 years ago Actions
Copy link
#3

VJ Updated by Victor Julien over 3 years ago Actions
Copy link
#4

VJ Updated by Victor Julien about 2 years ago Actions
Copy link
#5

JL Updated by Jeff Lucovsky almost 2 years ago · Edited Actions
Copy link
#6

VJ Updated by Victor Julien almost 2 years ago Actions
Copy link
#7

VJ Updated by Victor Julien over 1 year ago Actions
Copy link
#8

VJ Updated by Victor Julien over 1 year ago Actions
Copy link
#9

VJ Updated by Victor Julien over 1 year ago Actions
Copy link
#10

VJ Updated by Victor Julien over 1 year ago Actions
Copy link
#11

VJ Updated by Victor Julien over 1 year ago Actions
Copy link
#12

VJ Updated by Victor Julien 8 months ago Actions
Copy link
#13

VJ Updated by Victor Julien 8 months ago Actions
Copy link
#14

VJ Updated by Victor Julien 8 months ago Actions
Copy link
#15

Project

General

Profile

Suricata

Custom queries

Optimization #5672

smb: avoid unbounded hash maps

PA Updated by Philippe Antoine over 3 years ago ActionsCopy link #1

VJ Updated by Victor Julien over 3 years ago ActionsCopy link #2

VJ Updated by Victor Julien over 3 years ago ActionsCopy link #3

VJ Updated by Victor Julien over 3 years ago ActionsCopy link #4

VJ Updated by Victor Julien about 2 years ago ActionsCopy link #5

JL Updated by Jeff Lucovsky almost 2 years ago · Edited ActionsCopy link #6

VJ Updated by Victor Julien almost 2 years ago ActionsCopy link #7

VJ Updated by Victor Julien over 1 year ago ActionsCopy link #8

VJ Updated by Victor Julien over 1 year ago ActionsCopy link #9

VJ Updated by Victor Julien over 1 year ago ActionsCopy link #10

VJ Updated by Victor Julien over 1 year ago ActionsCopy link #11

VJ Updated by Victor Julien over 1 year ago ActionsCopy link #12

VJ Updated by Victor Julien 8 months ago ActionsCopy link #13

VJ Updated by Victor Julien 8 months ago ActionsCopy link #14

VJ Updated by Victor Julien 8 months ago ActionsCopy link #15

PA Updated by Philippe Antoine over 3 years ago Actions
Copy link
#1

VJ Updated by Victor Julien over 3 years ago Actions
Copy link
#2

VJ Updated by Victor Julien over 3 years ago Actions
Copy link
#3

VJ Updated by Victor Julien over 3 years ago Actions
Copy link
#4

VJ Updated by Victor Julien about 2 years ago Actions
Copy link
#5

JL Updated by Jeff Lucovsky almost 2 years ago · Edited Actions
Copy link
#6

VJ Updated by Victor Julien almost 2 years ago Actions
Copy link
#7

VJ Updated by Victor Julien over 1 year ago Actions
Copy link
#8

VJ Updated by Victor Julien over 1 year ago Actions
Copy link
#9

VJ Updated by Victor Julien over 1 year ago Actions
Copy link
#10

VJ Updated by Victor Julien over 1 year ago Actions
Copy link
#11

VJ Updated by Victor Julien over 1 year ago Actions
Copy link
#12

VJ Updated by Victor Julien 8 months ago Actions
Copy link
#13

VJ Updated by Victor Julien 8 months ago Actions
Copy link
#14

VJ Updated by Victor Julien 8 months ago Actions
Copy link
#15